Fix add timetravel timeout#1285
Merged
Merged
Conversation
sonic16x
force-pushed
the
add-timetravel-timeout
branch
from
35e7656 to
83f7e72
Compare
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
sonic16x
force-pushed
the
add-timetravel-timeout
branch
from
83f7e72 to
d2f4bdd
Compare
commit: |
shadowusr
approved these changes
Jul 6, 2026
shadowusr
left a comment
shadowusr
left a comment
Member
There was a problem hiding this comment.
LGTM, but I would mark the session as broken in case snapshot collection time outs.
sonic16x
force-pushed
the
add-timetravel-timeout
branch
from
d2f4bdd to
5adf7bd
Compare
sonic16x
force-pushed
the
add-timetravel-timeout
branch
from
5adf7bd to
dba269f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, if Time Travel snapshot collection hung, the test runner would wait forever with only a
Collecting Time Travel snapshots takes longer than expected. Waiting...warning. Now collection is aborted after a timeout and the run continues, loggingCollecting Time Travel snapshots timed out after 5000ms— thesnapshot is simply omitted from the report.